Fix csolution rpc codegen#9
Merged
Merged
Conversation
arneschmid
requested review from
brondani and
Copilot
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a compressed tarball output alongside the existing ZIP artifact in the codegen workflow.
- Adds a new
tar -czfstep to producecsolution-rpc.tar.gz - Updates the release upload action to include both ZIP and TAR files
Comments suppressed due to low confidence (2)
.github/workflows/codegen.yml:99
- [nitpick] The step name uses an all-caps acronym; consider using Title Case for consistency with other step names (e.g.,
Zip generated files).
- name: ZIP generated files
.github/workflows/codegen.yml:103
- [nitpick] Update any external documentation (README, contributor guide) to mention the new
.tar.gzartifact so users know they can download both the ZIP and TAR archives.
- name: TAR generated files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Added .tar.gz output to the codegen run
Changes
Checklist